Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds flag to update the version #456

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Adds flag to update the version #456

merged 1 commit into from
Nov 10, 2021

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Nov 10, 2021

Summary

Previously, update-buildpack-image-id would only allow you to update the id. In some cases, the id and version need to change in sync. For example, if you have buildpack abc v5.4.10, you may want to map that to buildpack xyz v1.0.0. This will now rewrite the metadata such that both the id and the version are updated. The current id and version are pulled from the metadata on the existing buildpack (arg #1) image.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Previously, update-buildpack-image-id would only allow you to update the id. In some cases, the id and version need to change in sync. For example of you have buildpack abc v5.4.10, you may want to map that to buildpack xyz v1.0.0. This will now rewrite the metadata such that both the id and the version are updated. The current id and version are pulled from the metadata on the existing buildpack (arg #1) image.

Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Nov 10, 2021
@dmikusa dmikusa requested a review from a team November 10, 2021 19:37
@dmikusa dmikusa merged commit 1bd8678 into main Nov 10, 2021
@dmikusa dmikusa deleted the image-update branch November 10, 2021 19:39
This was referenced Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant