Also push MAJOR and MAJOR.MINOR tags when releasing

[pbusko]

Summary

As decided in the RFC 39

Checklist

• I have viewed, signed, and submitted the Contributor License Agreement.
• I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
• I have added an integration test, if necessary.
• I have reviewed the styleguide for guidance on my code quality.
• I'm happy with the commit history on this PR (I have rebased/squashed as needed).

[dmikusa]

Thanks for the PR, we'll try to take a look at this shortly. Just an FYI, changes to the pipeline require additional review and testing so they can take a little longer to be merged.

Quick note, you need to run go generate because this PR modifies shell scripts. Running go generate will update the scripts in the statik blob, which is what actually is distributed. Can you run that & update your PR?

Thanks!

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Philipp Stehle (323b3db)

[pbusko]

Quick note, you need to run go generate because this PR modifies shell scripts. Running go generate will update the scripts in the statik blob, which is what actually is distributed. Can you run that & update your PR?

Thanks for the quick reply @dmikusa-pivotal! I've updated the PR with the generated files.

[phil9909]

Running go generate will update the scripts in the statik blob, which is what actually is distributed.

I guess its actually go generate ./... or go generate ./octo

[c0d1ngm0nk3y]

@dmikusa-pivotal Could you have another look? I think this is ready to merge (see paketo-buildpacks/github-config#378).

[dmikusa]

I also had a diff with octo/statik/statik.go. When I run go generate ./... from the project root. Can you try running that one more time? Also, what is your OS? I'm on a Mac, I wonder if there is some difference there?

Side note: you can run go run cmd/statik/main.go and it'll dump what's in the statik file. If you pipe to a file before and after running go generate you can see what's changed in the file (diff before after).

[dmikusa]

Sorry, I don't mean to rush, especially after I have delayed on this one (sorry for that), but I wanted to let you know I'll be cutting a release of pipeline builder tomorrow morning US EST. If you're able to address the feedback above, I can merge this in before that release.

Again, no rush. Just wanted to give you a heads up. That would get your change merged in ASAP.

[pbusko]

Sorry for the delayed response. We addressed all comments, could you please take another look?