-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow update tasks to bump version numbers in CPE & PURL #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prior to this PR, CPE & PURL metadata would not be updated in PRs that are generated to bump a dependency version - This PR allows the update job to bump the CPE & PURL as well as the version. This requires paketo-buildpacks/libpak#112. - For this to work, actions don't need to be updated. The default values will use the same pattern for version, CPE & PURL. This works for the majority of actions. - It doesn't work for JVM related actions. This is because Java 8 has a one-off CPE format. This is being supported by modifying the actions for JVMs such that they also output a CPE. This needs to be paired with a CPE Pattern, which would be specified in the pipeline-descriptor.yml file. - This PR also modifies the descriptor such that you can set the cpe and purl pattern. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:enhancement
A general enhancement
semver:minor
A change requiring a minor version bump
labels
Dec 2, 2021
Co-authored-by: David O'Sullivan <31728678+pivotal-david-osullivan@users.noreply.github.com>
Co-authored-by: David O'Sullivan <31728678+pivotal-david-osullivan@users.noreply.github.com>
Co-authored-by: David O'Sullivan <31728678+pivotal-david-osullivan@users.noreply.github.com>
Co-authored-by: David O'Sullivan <31728678+pivotal-david-osullivan@users.noreply.github.com>
Co-authored-by: David O'Sullivan <31728678+pivotal-david-osullivan@users.noreply.github.com>
Co-authored-by: David O'Sullivan <31728678+pivotal-david-osullivan@users.noreply.github.com>
Co-authored-by: David O'Sullivan <31728678+pivotal-david-osullivan@users.noreply.github.com>
Co-authored-by: David O'Sullivan <31728678+pivotal-david-osullivan@users.noreply.github.com>
pivotal-david-osullivan
approved these changes
Dec 3, 2021
This was referenced Dec 3, 2021
This was referenced Dec 3, 2021
This was referenced Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use Cases
Enable update jobs to bump version numbers in CPEs & PURLs.
Checklist