Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes edge case where versions have prerelease info #503

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Jan 6, 2022

Summary

Prior to this PR, if a version key in the index.yml had prerelease info, there would be an _ and then the prerelease info. This isn't valid semver, so it would break the pipeline. This change replaces the _ with a - which makes it valid semver.

Use Cases

Fixes broken runs like https://github.com/pivotal-cf/tanzu-appdynamics/runs/4732140660?check_suite_focus=true

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Prior to this PR, if a version key in the index.yml had prerelease info, there would be an `_` and then the prerelease info. This isn't valid semver, so it would break the pipeline. This change replaces the `_` with a `-` which makes it valid semver.

Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Jan 6, 2022
@dmikusa dmikusa requested a review from a team January 6, 2022 21:22
@dmikusa dmikusa merged commit 39d5d1d into main Jan 6, 2022
@dmikusa dmikusa deleted the cf-index branch January 6, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant