-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in pre-release information for tomee versions #552
Merged
dmikusa
merged 3 commits into
paketo-buildpacks:main
from
garethjevans:tomee-pre-release
Feb 10, 2022
Merged
Add in pre-release information for tomee versions #552
dmikusa
merged 3 commits into
paketo-buildpacks:main
from
garethjevans:tomee-pre-release
Feb 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikusa
added
semver:patch
A change requiring a patch version bump
type:task
A general task
labels
Feb 10, 2022
dmikusa
requested changes
Feb 10, 2022
Co-authored-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
approved these changes
Feb 10, 2022
Looks good. Once this job finishes, it'll update the action tagged as |
This was referenced Feb 15, 2022
This was referenced Feb 15, 2022
This was referenced Feb 15, 2022
This was referenced Feb 15, 2022
This was referenced Feb 25, 2022
This was referenced Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added back in pre-release information in to the tomee dependency checker. Tomee versioning appears to follow the same process as Tomcat versioning where we can expect both
9.0.0
and9.0.0-M7
versions to exist at the same time.e.g. with Tomcat we have:
https://archive.apache.org/dist/tomcat/tomcat-10/v10.0.0-M9/ and https://archive.apache.org/dist/tomcat/tomcat-10/v10.0.0/
Tested locally with:
Use Cases
This PR will allow us to determine the difference between a 9.0.0 and 9.0.0-M7 release
Checklist
fyi @dmikusa-pivotal