Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in pre-release information for tomee versions #552

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

garethjevans
Copy link
Contributor

@garethjevans garethjevans commented Feb 10, 2022

Summary

Added back in pre-release information in to the tomee dependency checker. Tomee versioning appears to follow the same process as Tomcat versioning where we can expect both 9.0.0 and 9.0.0-M7 versions to exist at the same time.

e.g. with Tomcat we have:

https://archive.apache.org/dist/tomcat/tomcat-10/v10.0.0-M9/ and https://archive.apache.org/dist/tomcat/tomcat-10/v10.0.0/

Tested locally with:

❯ INPUT_URI=https://downloads.apache.org/tomee INPUT_MAJOR=7 go run actions/tomee-dependency/main.go
::set-output name=sha256::ee4fd96e0b308b40325c32376e4179d1620791fc76e38943d7337b409f445d3e
::set-output name=uri::https://downloads.apache.org/tomee/tomee-7.1.4/apache-tomee-7.1.4-webprofile.tar.gz
::set-output name=version::7.1.4
❯ INPUT_URI=https://downloads.apache.org/tomee INPUT_MAJOR=8 go run actions/tomee-dependency/main.go
::set-output name=sha256::5f64747ddd17187a8064807e6bd548773041921b0769e708357bb79f07f18a28
::set-output name=uri::https://downloads.apache.org/tomee/tomee-8.0.9/apache-tomee-8.0.9-webprofile.tar.gz
::set-output name=version::8.0.9
❯ INPUT_URI=https://downloads.apache.org/tomee INPUT_MAJOR=9 go run actions/tomee-dependency/main.go
::set-output name=sha256::a083775996a56fbb3830f549b18b6c9b9ed42e82aac9af2e1abc719e13782b0f
::set-output name=uri::https://downloads.apache.org/tomee/tomee-9.0.0-M7/apache-tomee-9.0.0-M7-webprofile.tar.gz
::set-output name=version::9.0.0-M7

Use Cases

This PR will allow us to determine the difference between a 9.0.0 and 9.0.0-M7 release

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

fyi @dmikusa-pivotal

@garethjevans garethjevans requested a review from a team February 10, 2022 08:15
@dmikusa dmikusa added semver:patch A change requiring a patch version bump type:task A general task labels Feb 10, 2022
actions/tomee-dependency/main.go Outdated Show resolved Hide resolved
actions/tomee-dependency/main.go Outdated Show resolved Hide resolved
garethjevans and others added 2 commits February 10, 2022 19:46
Co-authored-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa merged commit de08cba into paketo-buildpacks:main Feb 10, 2022
@dmikusa
Copy link
Contributor

dmikusa commented Feb 10, 2022

Looks good. Once this job finishes, it'll update the action tagged as main. If you're using the main tag, your workflows should just pick up the new action. No release or update of pipeline-builder required.

@garethjevans garethjevans deleted the tomee-pre-release branch February 10, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants