Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Tempdir with system default #633

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Don't use Tempdir with system default #633

merged 1 commit into from
Apr 14, 2022

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Apr 14, 2022

Summary

Github Actions doesn't have a /tmp directory so this PR switches from using Tempdir to using the present directory for output of the body & name. It then supplies a directory to Tempdir so that it puts the tempfiles into $RUNNER_TEMP for extracting TAR files.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Github Actions doesn't have a `/tmp` directory so this PR switches from using Tempdir to using the present directory for output of the body & name. It then supplies a directory to Tempdir so that it puts the tempfiles into `$RUNNER_TEMP` for extracting TAR files.

Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Apr 14, 2022
@dmikusa dmikusa requested a review from a team April 14, 2022 14:38
@dmikusa dmikusa merged commit 1401f2c into main Apr 14, 2022
@dmikusa dmikusa deleted the no-temp branch April 14, 2022 14:47
This was referenced Apr 19, 2022
This was referenced Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants