Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in a GCR service key from input #645

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Pull in a GCR service key from input #645

merged 1 commit into from
Apr 18, 2022

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Apr 15, 2022

Summary

This adds support to read a GCR service key from the action input if that is required to fetch images for the purpose of getting metadata to include in draft-release notes.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa added type:task A general task semver:patch A change requiring a patch version bump labels Apr 15, 2022
@dmikusa dmikusa requested a review from a team April 15, 2022 20:58
@dmikusa dmikusa merged commit 0b9bf18 into main Apr 18, 2022
@dmikusa dmikusa deleted the drft-imgs branch April 18, 2022 12:49
This was referenced Apr 19, 2022
This was referenced Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant