Sort by Strings is not totally accurate #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a couple of the actions, we were sorting an array of string versions. String versions do not sort correctly though under some circumstances, like if you have minor/patch releases in the list that are both less than and greater than 10. You get a sort like 1, 10, 11, 2, 3, 4, etc.. not 1, 2, 3, 4, 10, 11. This can cause updates to be missed. This PR rewrites the two impacted actions such that they are using Semver to sort and pick the latest order, which guarantees that we get the most recent release. This PR also makes some optimizations so that the version number is loaded from metadata instead of the JVM file, or that we only download and read the version from at least one JVM. In addition, it removes support for Java 8 from GraalVM, which dropped Java 8 support. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:bug
| for _, a := range r.Assets { | ||
| if globRegex.MatchString(*a.Name) { | ||
| version := tag[1] | ||
| if strings.HasPrefix(tag[1], "8u") { |
There was a problem hiding this comment.
Suggested change
| if strings.HasPrefix(tag[1], "8u") { | |
| if strings.HasPrefix(version, "8u") { |
pivotal-david-osullivan
approved these changes
May 9, 2022
This was referenced May 25, 2022
This was referenced May 25, 2022
This was referenced May 25, 2022
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a couple of the actions, we were sorting an array of string versions. String versions do not sort correctly though under some circumstances, like if you have minor/patch releases in the list that are both less than and greater than 10. You get a sort like 1, 10, 11, 2, 3, 4, etc.. not 1, 2, 3, 4, 10, 11. This can cause updates to be missed.
This PR rewrites the two impacted actions such that they are using Semver to sort and pick the latest order, which guarantees that we get the most recent release. This PR also makes some optimizations so that the version number is loaded from metadata instead of the JVM file, or that we only download and read the version from at least one JVM.
In addition, it removes support for Java 8 from GraalVM, which dropped Java 8 support.
Use Cases
Checklist