Fixes foojay action, which was missing some updates #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects the following issues: - Versions with a fourth digit were skipped, like 11.0.14.1 - Versions were incorrectly sorted [1], now using the latest field to pick the latest version - If an invalid distro was set, it would work and the API is not validating. It just does not filter at all, which returns all versions and confusing results. This PR validates the distro entered and panics if its bad. [1] - This happens due to some legacy issues in how we manage semver. If a version is not semver or if it's semver but has a pre-release or post-release number, then we squash all that to the format `major.minor.patch-pre` which isn't correct but changing it would require a lot of investigation to track down what it might possibly impact. At any rate, because we do this technically 11.0.14-1 is less than 11.0.14 and so 11.0.14 is picked despite what we really want being 11.0.14-1 (which was 11.0.14.1). Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
dmikusa
added
type:bug
pivotal-david-osullivan
approved these changes
May 9, 2022
This was referenced May 25, 2022
This was referenced May 25, 2022
This was referenced May 25, 2022
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Corrects the following issues:
[1] - This happens due to some legacy issues in how we manage semver. If a version is not semver or if it's semver but has a pre-release or post-release number, then we squash all that to the format
major.minor.patch-prewhich isn't correct but changing it would require a lot of investigation to track down what it might possibly impact. At any rate, because we do this technically 11.0.14-1 is less than 11.0.14 and so 11.0.14 is picked despite what we really want being 11.0.14-1 (which was 11.0.14.1).Use Cases
Checklist