Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack BOM RFC #125

Closed
wants to merge 5 commits into from
Closed

Stack BOM RFC #125

wants to merge 5 commits into from

Conversation

sophiewigmore
Copy link
Member

@sophiewigmore sophiewigmore commented Nov 8, 2021

Summary

Readable

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sophiewigmore sophiewigmore marked this pull request as ready for review November 8, 2021 22:25
@sophiewigmore sophiewigmore requested a review from a team as a code owner November 8, 2021 22:25
text/stacks/0003-sbom-formats.md Outdated Show resolved Hide resolved
text/stacks/0003-sbom-formats.md Outdated Show resolved Hide resolved
text/stacks/0003-sbom-formats.md Outdated Show resolved Hide resolved
sophiewigmore and others added 3 commits November 8, 2021 18:39
Co-authored-by: Ryan Moran <155736+ryanmoran@users.noreply.github.com>
Co-authored-by: Ryan Moran <155736+ryanmoran@users.noreply.github.com>
Co-authored-by: Ryan Moran <155736+ryanmoran@users.noreply.github.com>
Copy link
Member

@brayanhenao brayanhenao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dmikusa
Copy link
Contributor

dmikusa commented Nov 9, 2021

Same. +1 looks good.

@dmikusa dmikusa self-requested a review November 9, 2021 16:19
@ryanmoran
Copy link
Member

This looks great! We should block on the upstream RFC getting merged though so that we can track any changes between now and then.

sophiewigmore added a commit to paketo-buildpacks/stacks that referenced this pull request Nov 19, 2021
- Implements paketo-buildpacks/rfcs#125
- Uses layer addition code from github.com/sclevine/cnb-sbom
- Includes basic BOM generation and attachment logic
sophiewigmore added a commit to paketo-buildpacks/stacks that referenced this pull request Nov 19, 2021
- Implements paketo-buildpacks/rfcs#125
- Uses layer addition code from github.com/sclevine/cnb-sbom
- Includes basic BOM generation and attachment logic
sophiewigmore added a commit to paketo-buildpacks/stacks that referenced this pull request Nov 29, 2021
- Although not consistent with github.com/paketo-buildpacks/rfcs/pull/125, it is consistent with
  comments in the upstream CNB, and can be easily removed.
sophiewigmore added a commit to paketo-buildpacks/stacks that referenced this pull request Nov 29, 2021
- Although not consistent with github.com/paketo-buildpacks/rfcs/pull/125, it is consistent with
  comments in the upstream CNB, and can be easily removed.
brayanhenao pushed a commit to paketo-buildpacks/stacks that referenced this pull request Dec 9, 2021
* Add run image BOM

- Implements paketo-buildpacks/rfcs#125
- Uses layer addition code from github.com/sclevine/cnb-sbom
- Includes basic BOM generation and attachment logic

* use specific alpine tag in bom generation test

* Change bom file name to include original image digest

- Although not consistent with github.com/paketo-buildpacks/rfcs/pull/125, it is consistent with
  comments in the upstream CNB, and can be easily removed.

* generate Squashed Syft output

* Attach SBOM using feature flag

* Assert SBOM doesn't appear when not flagged

* Adds experimental SBOM support in create-stack action

Co-authored-by: Ryan Moran <rmoran@vmware.com>
Co-authored-by: Sophie Wigmore <swigmore@vmware.com>
@sophiewigmore
Copy link
Member Author

Closing out for now due to inactivity. Will re-open or create a new RFC when the direction upstream is definitive.

@ryanmoran ryanmoran deleted the stack-syft-bom branch July 18, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants