Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jammy Builders #202

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Jammy Builders #202

merged 3 commits into from
Jun 14, 2022

Conversation

fg-j
Copy link

@fg-j fg-j commented May 23, 2022 •
edited

Summary

Resolves #201

Readable

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@fg-j fg-j requested a review from a team as a code owner May 23, 2022 23:02
robdimsdale
robdimsdale approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@robdimsdale robdimsdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me - I don't have strong opinions on some of the decisions (e.g. dropping the builder dockerhub repository has pros and cons and I would be fine with either direction)

@fg-j fg-j merged commit 8113fb4 into main Jun 14, 2022
@fg-j fg-j deleted the jammy-builders branch June 14, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdimsdale robdimsdale robdimsdale approved these changes

@ryanmoran ryanmoran ryanmoran approved these changes

@ForestEckhardt ForestEckhardt ForestEckhardt approved these changes

@sophiewigmore sophiewigmore sophiewigmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create an RFC for Builder Variations
5 participants
@fg-j @ryanmoran @robdimsdale @ForestEckhardt @sophiewigmore