Contributes expanded classpath during native image builds #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekcasey
added
semver:minor
ekcasey
force-pushed
the
native-image-classpath
branch
from
04fc208 to
82df8e3
Compare
ekcasey
changed the title
ekcasey
added a commit
to paketo-buildpacks/native-image
that referenced
this pull request
Mar 10, 2021
…-image-build Removes Boot specific logic from the buildpack. * Renames buildpack ID from paketo-buildpack/spring-boot-native-image to paketo-buildpacks/native-image-build * Deprecates BP_BOOT_NATIVE_IMAGE_* config values in favor of BP_NATIVE_* * Removes check for spring-native or spring-graalvm-native dependency * Relies on upstream buildpacks to properly set CLASSPATH for boot JARs (see paketo-buildpacks/spring-boot#68) Other changes: * Requests native-image tool from paketo-buildpacks/graalvm using 'native-image-builder' plan entry (see paketo-buildpacks/graalvm#61) Signed-off-by: Emily Casey <ecasey@vmware.com>
ekcasey
added a commit
to paketo-buildpacks/native-image
that referenced
this pull request
Mar 10, 2021
…-image-build Removes Boot specific logic from the buildpack. * Renames buildpack ID from paketo-buildpack/spring-boot-native-image to paketo-buildpacks/native-image-build * Deprecates BP_BOOT_NATIVE_IMAGE_* config values in favor of BP_NATIVE_* * Removes check for spring-native or spring-graalvm-native dependency * Relies on upstream buildpacks to properly set CLASSPATH for boot JARs (see paketo-buildpacks/spring-boot#68) Other changes: * Requests native-image tool from paketo-buildpacks/graalvm using 'native-image-builder' plan entry (see paketo-buildpacks/graalvm#61) Signed-off-by: Emily Casey <ecasey@vmware.com>
ekcasey
force-pushed
the
native-image-classpath
branch
from
82df8e3 to
23fa8f7
Compare
Contribute appends application classes and entries from classpath.idx to the build time classpath. In a JVM application the Spring Boot Loader would make these modifications to the classpath when the executable JAR or WAR is launched. To set the classpath properly for a native-image build the buildpack must replicate this behavior. Signed-off-by: Emily Casey <ecasey@vmware.com>
ekcasey
force-pushed
the
native-image-classpath
branch
from
23fa8f7 to
a62c08b
Compare
ekcasey
added a commit
to paketo-buildpacks/native-image
that referenced
this pull request
Mar 10, 2021
…-image-build Removes Boot specific logic from the buildpack. * Renames buildpack ID from paketo-buildpack/spring-boot-native-image to paketo-buildpacks/native-image-build * Deprecates BP_BOOT_NATIVE_IMAGE_* config values in favor of BP_NATIVE_* * Removes check for spring-native or spring-graalvm-native dependency * Relies on upstream buildpacks to properly set CLASSPATH for boot JARs (see paketo-buildpacks/spring-boot#68) Other changes: * Requests native-image tool from paketo-buildpacks/graalvm using 'native-image-builder' plan entry (see paketo-buildpacks/graalvm#61) Signed-off-by: Emily Casey <ecasey@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a native-image, contribute appends application classes and entries from
classpath.idxto the build-timeCLASSPATH.In a JVM application the Spring Boot Loader would make these modifications to the classpath when the executable JAR
or WAR is launched. To set the classpath properly for a native-image build the buildpack must replicate this behavior.
Also some minor refactoring.