fix: add tests #4
Conversation
Signed-off-by: Michael Dawson <mdawson@devrus.com>
| _, err = fmt.Fprintf(builderConfigFile, ` | ||
| [stack] | ||
| build-image = "%s:latest" | ||
| id = "io.buildpacks.stacks.ubi8" | ||
| run-image = "%s:latest" | ||
| `, |
There was a problem hiding this comment.
it seems like this test is only gong to test out the basic run image scenario. Are you planning to add any sort of test for the other run images?
There was a problem hiding this comment.
I left that out of this initial set of testing as I think we likely want some testing of the runtime in the run images (in the initial case of the Node.js runtime), but that requires us having a working published extension, which in turn requires this stack to be published.
I could add the basic testing which is done for the default build/run but I was thinking it would be better to wait until we can do a test that validates the basic functionality of the runtime in the run images.
There was a problem hiding this comment.
@mhdawson can we capture this in an issue?
There was a problem hiding this comment.
@sophiewigmore created here - #6
Co-authored-by: Sophie Wigmore <sophiemwigmore@gmail.com>
Summary
Use Cases
Checklist