Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add images.json to build image #94

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

mhdawson
Copy link
Member

Refs: #88

The plan is to use it in the extensions to find the run images instead of data in the extension.toml file

Summary

Include the images.json file in the base image in the directory /etc/buildpacks

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Refs: paketo-community#88

The plan is to use it in the extensions to find the run
images instead of data in the extension.toml file

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson mhdawson requested a review from a team as a code owner July 23, 2024 23:01
@sophiewigmore
Copy link
Member

@mhdawson can you remind me what this file is for?

@mhdawson
Copy link
Member Author

mhdawson commented Jul 24, 2024

@sophiewigmore we currently use this file when we build the stack in order to drive the generation of the build and run images. For example in the case of Node.js it currently says that we build/publish run images for Node.js 16,18, and 20. It includes the info we need for building and publishing the containers.

We want to start using this in the node and java extensions as well. It already has the info needed to publish the container so we can use that same information to get the info for the run image that the extension will specify that the application should be switched onto by the extension.

Currently we've baked that information either into the extention.toml (in the Node.js case) by leveraging the dependency section or into the extension itself (I think in the java case).

Talking with @BarDweller it seemed much cleaner to pull this from the images.json file so that the extension does not need to be updated when new versions of Node.js or Java are supported by the stack. It will also make supporting multiple versions of ubi (for example ubi9) easier as the same extension would work with both stacks, the build image for ubi 9 would just contain a different images.json that the build image for ubi8.

Tying the available images to what is used to build the run images makes sense to us because they need to be kept in sync as the extension must swtich to one of the run images that has been built.

@mhdawson mhdawson added the semver:minor A change requiring a minor version bump label Jul 24, 2024
@mhdawson
Copy link
Member Author

mhdawson commented Aug 6, 2024

@sophiewigmore ping?

@sophiewigmore
Copy link
Member

@mhdawson sorry I missed your comment a couple. weeks ago 🙈 thanks for the details

@sophiewigmore sophiewigmore merged commit bec679d into paketo-community:main Aug 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants