Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Run Image Names, Add Override Env Var, Update tests. #7

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

BarDweller
Copy link
Contributor

Summary

The Stack PR creating the Run Images has landed, so can replace the placeholder/best-guess run image names with the real ones now =) And then add tests, and provide an override to allow for escape hatch situations.

Use Cases

Building java apps with the extension =)

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@BarDweller BarDweller requested a review from a team as a code owner November 1, 2023 16:09
@dmikusa dmikusa added type:task A general task semver:patch A change requiring a patch version bump labels Nov 1, 2023
@dmikusa dmikusa merged commit a55e264 into paketo-community:main Nov 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants