Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Excavator: Upgrades Baseline to the latest version #4

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Nov 27, 2019

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.36.0

Type Description Link
Fix Replace refaster StreamEmpty with error prone StreamOfEmpty to allow refactors to retain type arguments. palantir/gradle-baseline#1068
Improvement RedundantMethodReference check to avoid unnecessary method references palantir/gradle-baseline#1069
Improvement PreferAssertj iterable-map fix retains map type parameters palantir/gradle-baseline#1071

2.37.0

Type Description Link
Improvement refaster will automatically fix up assertions between primitives (a == b) to provide better error messages palantir/gradle-baseline#1078
Improvement Error prone AssertjPrimitiveComparison for primitive comparisons

Prefer using AssertJ fluent comparisons over logic in an assertThat
statement for better failure output. assertThat(a == b).isTrue()
failures report 'expected true' where assertThat(a).isEqualTo(b)
provides the expected and actual values.
palantir/gradle-baseline#1079

2.38.0

Type Description Link
Improvement We now run error-prone 2.3.4, to benefit from smarter static analysis, and hopefully pick up the claimed performance Improvements:

> 40% speedup when run against Google's codebase with errors enabled.
palantir/gradle-baseline#1082

2.39.0

Type Description Link
Improvement Baseline now depends on mockito-errorprone to get Mockito error-prone checks. palantir/gradle-baseline#1085

2.40.0

Type Description Link
Improvement Error prone CatchSpecificity and ThrowSpecificity to avoid unnecessarily broad throwables.

Prefer more specific catch types than Exception and Throwable.
When methods are updated to throw new checked exceptions they expect
callers to handle failure types explicitly. Catching broad types defeats
the type system. By catching the most specific types possible we
leverage existing compiler functionality to detect unreachable code.
palantir/gradle-baseline#1074
Improvement For repos that opted into palantir-java-format, the arguments of SafeArg.of (when it's a last argument) are no longer unexpectedly split onto the next line. palantir/gradle-baseline#1075

2.40.1

Type Description Link
Fix The PreferJavaTimeOverload error-prone check is turned off as it produces noisy false positives relating to custom AssertJ utilities. palantir/gradle-baseline#1094

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 6 times, most recently from 1575300 to 2216c7a Compare December 5, 2019 20:03
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 2216c7a to daf3d08 Compare December 6, 2019 03:25
@mccheah mccheah merged commit 6b643d9 into develop Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants