[core] fix: toasters closing immediately on hover if timeout is set…

… to 0 (#6783)
palantir · May 3, 2024 · 070b802 · 070b802 · svc-palantir-github · May 3, 2024
1 parent 488658d
commit 070b802
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/core/src/components/toast/toast2.tsx b/packages/core/src/components/toast/toast2.tsx
@@ -43,12 +43,15 @@ export const Toast2 = React.forwardRef<HTMLDivElement, ToastProps>((props, ref)
     const startTimeout = React.useCallback(() => setIsTimeoutStarted(true), []);
     const clearTimeout = React.useCallback(() => setIsTimeoutStarted(false), []);
 
+    // Per docs: "Providing a value less than or equal to 0 will disable the timeout (this is discouraged)."
+    const isTimeoutEnabled = timeout != null && timeout > 0;
+
     // timeout is triggered & cancelled by updating `isTimeoutStarted` state
     useTimeout(
         () => {
             triggerDismiss(true);
         },
-        isTimeoutStarted && timeout !== undefined ? timeout : null,
+        isTimeoutStarted && isTimeoutEnabled ? timeout : null,
     );
 
     // start timeout on mount or change, cancel on unmount