Skip to content

Commit

Permalink
use default generics for ContextMenuTarget & HotkeysTarget
Browse files Browse the repository at this point in the history
fixes compiler error with latest types (due to third type param in ComponentLifecycle)
  • Loading branch information
Gilad Gray committed May 29, 2018
1 parent c9b71ca commit c36aaae
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { isFunction, safeInvoke } from "../../common/utils";
import { isDarkTheme } from "../../common/utils/isDarkTheme";
import * as ContextMenu from "./contextMenu";

export interface IContextMenuTarget extends React.Component<any, any> {
export interface IContextMenuTarget extends React.Component {
renderContextMenu(e: React.MouseEvent<HTMLElement>): JSX.Element | undefined;
onContextMenuClose?(): void;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/components/hotkeys/hotkeysTarget.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { isFunction, safeInvoke } from "../../common/utils";
import { IHotkeysProps } from "./hotkeys";
import { HotkeyScope, HotkeysEvents } from "./hotkeysEvents";

export interface IHotkeysTarget extends React.Component<any, any>, React.ComponentLifecycle<any, any> {
export interface IHotkeysTarget extends React.Component {
/** @internal */
globalHotkeysEvents?: HotkeysEvents;

Expand Down

1 comment on commit c36aaae

@blueprint-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use default generics for ContextMenuTarget & HotkeysTarget

Preview: documentation | landing | table | github pages

Please sign in to comment.