[icons] fix(IconLoader): improve performance of isValidIconName (#6393)

Co-authored-by: Nikita Morozov <nmorozov@palantir.com>
palantir · Sep 20, 2023 · d72e6de · d72e6de · adidahiya · Sep 20, 2023
1 parent e0687b5
commit d72e6de
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/icons/src/iconLoader.ts b/packages/icons/src/iconLoader.ts
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { type IconName, IconNames } from "./iconNames";
+import { type IconName, IconNames, IconNamesSet } from "./iconNames";
 import { type IconPaths, IconSize } from "./iconTypes";
 import { wrapWithTimer } from "./loaderUtils";
 
@@ -138,8 +138,7 @@ export class Icons {
      * @returns true if the given string is a valid {@link IconName}
      */
     public static isValidIconName(iconName: string): iconName is IconName {
-        const allIcons: IconName[] = Object.values(IconNames);
-        return allIcons.indexOf(iconName as IconName) >= 0;
+        return IconNamesSet.has(iconName as IconName);
     }
 }
 

diff --git a/packages/icons/src/iconNames.ts b/packages/icons/src/iconNames.ts
@@ -36,3 +36,5 @@ export const IconNames = {
     ...IconNamesNew,
     ...IconNamesLegacy,
 };
+
+export const IconNamesSet = new Set(Object.values(IconNames));