Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Resolve differences between <EditableCell> and <EditableName> #1262

Closed
cmslewis opened this issue Jun 21, 2017 · 1 comment
Closed

Comments

@cmslewis
Copy link
Contributor

Bug report

  • Package version(s): v1.20.0

Changes proposed

There are some differences between EditableCell and EditableName that we should resolve:

@gscshoyru
Copy link
Contributor

Note: so far as I can tell, doing the first part here is going to require cloning the results of renderName the same way we do for table cells, so it knows what index it is. Is this alright? I'm somewhat loathe to do more cloning, 'cause I know it tends to impact perf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants