[Table] Make reordering work in the table example #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmslewis
commented
Jun 21, 2017
| 10000, | ||
| 1000000, | ||
| 1000, | ||
| 100000, |
There was a problem hiding this comment.
Rendering 1,000,000 cells now throws Maximum Call Stack Exceeded errors because I'm saving the rows in memory to retain their order, which I wasn't doing before. So I got rid of that option for now.
Fix row insertionPreview: documentation | table |
|
This doesn't have the reorder handle icon in the interaction bar? |
llorca
approved these changes
Jun 22, 2017
Fix row insertionPreview: documentation | table |
Merge branch 'master' into cl/table-example-reorderingPreview: documentation | table |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Column and row reordering now work in the Table example (had to totally change the data store backing the example, hence the new
DenseGridMutableStore.I discovered a bunch of bugs in this work, including:
Screenshot