-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue changing month and day on dateinput in Internet Explorer 11 #2924
Comments
@timothymcooley I cannot reproduce this on IE. |
@giladgray Also, I discovered that the issue is a bit more widespread than in the initial ticket. Anytime I click two different inputs on the popover it closes. Examples found on https://blueprintjs.com/docs/#datetime/dateinput:
Is there any more information that might be useful? |
@timothymcooley perhaps you have some time to investigate this issue? check out the repo and develop on it in IE. add debugger/print statements as necessary to understand if the click events are getting lost. all the calendar logic is handled by react-day-picker. |
@giladgray Hello ! First of all, this is how I reproduce it: I found out that, after a month change, this function
is never called on IE. When the month has changed, the popup is closed by a blur event. blueprint/packages/datetime/src/dateInput.tsx Lines 167 to 170 in ac38072
blueprint/packages/datetime/src/dateInput.tsx Lines 381 to 390 in ac38072
There is a difference between Chrome and IE in the 'relatedTarget'. On IE, as the relatedTarget is null, the popup is closed. On Chrome, the relatedTarget is not null, the 'else' part of the function is called and everything works. I don't really know how to fix this. By simply removing the call to I hope this will help you to fix this ! |
@knalinne thank you for the detailed report! at least we know where to focus our efforts to address this now 👍 and this definitely qualifies as a bug now! |
Environment
Steps to reproduce
Reproducible on the example: https://blueprintjs.com/docs/#datetime/dateinput
Note: You can change days within the same month
Actual behavior
Cannot change day and month at the same time using dateinput popover
Expected behavior
The day you clicked is actually selected
Possible solution
Unsure. It looks like the onChange for the dateinput doesn't actually fire on the click after changing months. I attempted to use the isUserChange boolean to prevent the changing month from firing the onChange but the issue persists.
The text was updated successfully, but these errors were encountered: