Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date range bug around December 2016 #391

Closed
raiju opened this issue Dec 27, 2016 · 3 comments
Closed

Date range bug around December 2016 #391

raiju opened this issue Dec 27, 2016 · 3 comments

Comments

@raiju
Copy link
Contributor

raiju commented Dec 27, 2016

Bug report

  • Package version(s): 1.4.0
  • Browser and OS versions: Chrome v55 & Firefox v50 on MacOs X 10.11.6

Steps to reproduce

  1. Open http://blueprintjs.com/docs/#components.datetime.daterangepicker
  2. Select December 2016 on the left part of the date range picker
  3. Notice the right picker now displays January 1996

Expected behavior

The right picker displays January 2017

image

@adidahiya
Copy link
Contributor

Looks like a duplicate of #289, which should've been fixed by #312? The expected behavior here is that December 2016 shows up on the right and you aren't able to advance past the max date.

@giladgray
Copy link
Contributor

giladgray commented Dec 28, 2016

This is not exactly a duplicate, the repro steps say to explicitly select December 2016 on the left calendar. But it is another way of triggering the same issue, which we can't really do anything about as it's part of the react-day-picker implementation.

In the example component, January 2017 is past the maxDate so the calendar wraps to the minDate.

@gpbl
Copy link

gpbl commented Jan 4, 2017

Hi people, I believe the header is wrong - it should say "January 2017" because that is the month being displayed (see gpbl/react-day-picker#243 (comment)).

@adidahiya adidahiya added the P2 label Jan 4, 2017
@giladgray giladgray self-assigned this Jan 6, 2017
giladgray pushed a commit that referenced this issue Jan 6, 2017
but disables the option, so it's for display only. this handles the Dec 2016 case in #391.
@giladgray giladgray added this to the 1.5.0 milestone Jan 6, 2017
giladgray added a commit that referenced this issue Jan 6, 2017
but disables the option, so it's for display only. this handles the Dec 2016 case in #391.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants