Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Popper.js v2.0 #4023

Closed
adidahiya opened this issue Mar 24, 2020 · 5 comments · Fixed by #4488
Closed

Upgrade to Popper.js v2.0 #4023

adidahiya opened this issue Mar 24, 2020 · 5 comments · Fixed by #4488
Assignees
@adidahiya
Labels
P2 Package: core Type: enhancement
Milestone
4.x

Comments

@adidahiya
Copy link
Contributor

v2 docs
@adidahiya adidahiya self-assigned this Mar 24, 2020
@adidahiya adidahiya mentioned this issue Mar 24, 2020
Closed
@LoiKos
Copy link

LoiKos commented Jul 28, 2020 •
edited
Loading

You may consider using React-Popper v2 i think it would be easier for you

@adidahiya
Copy link
Contributor Author

We're already using react-popper.

@alex-kinokon
Copy link

alex-kinokon commented Aug 22, 2020 •
edited
Loading

Will this be in 4.0?

@adidahiya adidahiya added this to the 4.x milestone Aug 24, 2020
@adidahiya
Copy link
Contributor Author

@proteriax yes, likely, but I don't have a concrete timeline for 4.0 yet

@adidahiya adidahiya mentioned this issue Jan 20, 2021
Merged
2 tasks
@jasongrout jasongrout mentioned this issue Jan 29, 2021
Merged
@justinbhopper
Copy link
Contributor

justinbhopper commented May 5, 2021 •
edited
Loading

@adidahiya Are there plans to transition @blueprintjs/core and @blueprintjs/select to use Popover.js v2.0? I would have thought the v4.0 milestone would be a good opportunity to make the switch, since it would undoubtedly be a breaking change to the API.

Ignore this comment. I see this is exactly what has been done on the v4 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adidahiya adidahiya

Labels
P2 Package: core Type: enhancement
Projects
None yet
Milestone
4.x
Development

Successfully merging a pull request may close this issue.

[popover2] feat: Popover2 and Tooltip2 components palantir/blueprint
4 participants
@adidahiya @alex-kinokon @LoiKos @justinbhopper