-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[popover2] feat: Popover2 and Tooltip2 components #4488
Conversation
core: fix lintPreviews: documentation | landing | table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self-review
packages/docs-app/src/examples/popover2-examples/popover2Example.tsx
Outdated
Show resolved
Hide resolved
packages/docs-app/src/examples/popover2-examples/popover2Example.tsx
Outdated
Show resolved
Hide resolved
fix lintPreviews: documentation | landing | table |
fix more lintPreviews: documentation | landing | table |
Have you considered using cypress.io for end-to-end/integration tests? In my (personal) opinion this library has many benefits over jest + selenium. The test runner itself is a free open source library and I haven't had so much fun writing end-to-end test with another tool yet. It's very fast and intuitive. They also provide a dashboard service that has a free plan for open source projects. |
@trixn86 I've looked at cypress but not used it myself yet. We need fast unit tests in Blueprint, so I don't think we can fully switch over to an ETE test suite and retain the kind of developer experience we currently have in this repo. I imagine that spinning up all the services necessary for ETE tests is slower than mocha+karma or jest+puppeteer, but if I'm wrong about that do let me know. |
Fixes #4023
Checklist
Changes proposed in this pull request:
@blueprintjs/popover2
<Popover>
:.bp3-popover-wrapper
wrapper element surrounding the target and overlay. Both the target and overlay are rendered out to the virtual DOM as siblings..bp3-popover-target
wrapper element surrounding the target as well. IfrenderTarget
prop is supplied, its return value will be rendered out directly to the DOM without a wrapper.<Tooltip2>
target which is a direct child of a<Popover2>
when the popover is open (<Popover>
would handle this automatically for you, with its wrapper element behavior).<Popover2>
is retained. In this case, a.bp3-popover-target
wrapper element will be generated around the target child, so we can atttach event handlers to it.openOnTargetFocus={true}
and hover interaction kinds), atabIndex
was previously generated and applied to the clonedprops.children
element directly. Now, thattabIndex
is applied to thebp3-popover2-target
wrapper element to increase the chance of this feature working in more situations.Reviewers should focus on:
renderTarget
APIScreenshot
(pretty much identical to Popover)
Not addressed in this PR