-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certain dialog/popover combinations mess up cursor/selection rendering in text inputs in Firefox #406
Comments
Blueprint 1.9.0 Simpler repro steps:
Bonus steps:
|
@llorca We hit this bug hard after rolling out a blueprint application last week and all of our users use firefox. Think you guys can take a look? It's causing our users a lot of pain |
Sorry about the pain, we'll take a look ASAP. In addition: after typing in the input with no cursor, clicking it clears it 👎 Something is very wrong |
@llorca I don't think that behavior is quite accurate. There is actually an invisible cursor in the text box, so if you carefully "highlight" half of your text after repro'ing and then hit delete, the "highlighted" text will disappear. You may have inadvertently highlighted the full text by double clicking or something similar |
Also, thank you for looking at this! |
You're right, nevermind. I can totally repro with your steps though, thanks 👍 |
If it helps trigger any ideas, I think the general form of the bug is "open two (layers of) dialogs and/or popovers, then close the first one you opened before you close the second one you opened". |
* fix bad index comparison in Overlay stack (fixes #406) * rename & compare to -1
Bug report
Steps to reproduce
This was found in one of our projects, but I found a way to demonstrate it on the Blueprint docs page:
<input type="text"/>
) after the docs-react-options div. (Using the page's "Search" bar does not work to reproduce the issue, due to its complex behaviors.)Actual behavior
While the bug is in effect, clicking on the text input does not display a cursor and selecting text in the box. It is in fact still possible to select text, but this is not represented visually. (This may be the same set of visual effects as the input not having focus.)
This applies to any text inputs that are already present on the page. (Some inputs may not appear to be affected in practice because they have popovers attached to them that trigger the "fixed" state.)
Expected behavior
Clicking on the text input shows a cursor and selecting the text highlights the selected portion.
Additional observations
By observing other triggers and fixes, I believe the bug is triggered if the dialog is closed while the popover is open, and fixed if the dialog is closed while the popover is not open.
In our application, I believe this is also triggered by closing a dialog that is opened via a button within a popover.
The text was updated successfully, but these errors were encountered: