Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip2+Button selection tabindex issue #4521

Closed
dlech opened this issue Feb 8, 2021 · 1 comment · Fixed by #4592
Closed

Tooltip2+Button selection tabindex issue #4521

dlech opened this issue Feb 8, 2021 · 1 comment · Fixed by #4592
Assignees
Milestone

Comments

@dlech
Copy link
Contributor

dlech commented Feb 8, 2021

Follow up to #4502

Environment

  • Package version(s): @blueprintjs/popover2@0.2.0
  • Operating System: Ubuntu 20.04
  • Browser name and version: Firefox 85.0

Code Sandbox

Link to a minimal repro (fork this code sandbox): https://codesandbox.io/s/blueprint-sandbox-forked-146cf?file=/src/CoreExample.tsx

Steps to reproduce

  1. click on a blank part of the browser
  2. press tab on the keyboard to focus the buttons
  3. notice that the selection indicator is rendered behind the buttons instead of in front
  4. try pressing spacebar to activate the button

Actual behavior

The selection indicator is behind the neighboring buttons. Also, the highlight looks different from the normal button highlight like it is selecting the tooltip rather than the button. And more importantly, the button can't be activated with the keyboard by pressing space.

image

Expected behavior

The UI should show the normal button selection highlight instead and should respond to keyboard activation.

image

Possible solution

@dlech dlech changed the title Tooltip2+Button selection z-index issue Tooltip2+Button selection z-index/tabindex issue Feb 8, 2021
@dlech dlech changed the title Tooltip2+Button selection z-index/tabindex issue Tooltip2+Button selection tabindex issue Feb 8, 2021
@adidahiya adidahiya self-assigned this Feb 8, 2021
@adidahiya adidahiya added this to the 4.x milestone Feb 8, 2021
@adidahiya adidahiya modified the milestones: 4.x, 4.0.0-beta.0 Mar 4, 2021
@seve
Copy link

seve commented Mar 15, 2021

Comparing the DOM between Popover1 and 2, it looks like the tabindex is attributed to the wrong element:

image (2)
image (3)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants