Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper Text for forms should have 'above input' option #5019

Closed
jheadrick2 opened this issue Nov 10, 2021 · 4 comments · Fixed by #5031
Closed

Helper Text for forms should have 'above input' option #5019

jheadrick2 opened this issue Nov 10, 2021 · 4 comments · Fixed by #5031

Comments

@jheadrick2
Copy link
Contributor

I would like to know if we can support the option to make the helper text in BP forms appear above the inputs instead of below them. I find that the helper text is often used as a direction or a label for the input, in which case, it makes more sense hierarchically to appear above the input. Attached is the desired visual:
image

@mud
Copy link
Contributor

mud commented Nov 10, 2021

Here's an example where a FormGroup can have arbitrary number of input groups. It ends up pushing down the helper text further down.

Screen Shot 2021-11-10 at 10 19 32 AM

@adidahiya
Copy link
Contributor

Ok, this makes sense to me, we can likely add this or accept a PR for this kind of option. @aycai do you have any thoughts?

@aycai
Copy link
Contributor

aycai commented Nov 15, 2021

Yep, chatted with @jheadrick2 about this, +1 to adding the option to have the helper text above the input (but below the label).

@jheadrick2 what spacing do you have in that screenshot? Looks reasonable there!

@mud
Copy link
Contributor

mud commented Nov 15, 2021

Awesome, I'm happy to do the implementation. Initial thought was to add a new labelHelperText prop that renders underneath the label, but still allow helperText to exist. Another option is to add a helperTextPosition to specify where helperText is rendered.

I lean towards the first option to add labelHelperText since there's no reason to restrict anyone from specifying content for both locations.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants