[core] feat(FormGroup): add support for "sub label" text #5031
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5019
Checklist
Changes proposed in this pull request:
To resolve #5019 this PR adds a new prop
labelHelperText
toFormGroup
which adds helperText betweenlabel
andchildren
.Reviewers should focus on:
We could have ignored the
labelHelperText
iflabel
is empty, but decided against it as it seemed to add unnecessary complexity. Similarly, there's no restriction on specifying only one type of helperText. It looks slightly odd when both helper texts are used, but we may end up using both with one of our use case where we have a list of fields specified aschildren
.Screenshot