Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat(FormGroup): add support for "sub label" text #5031

Merged
merged 4 commits into from
Dec 1, 2021

Conversation

mud
Copy link
Contributor

@mud mud commented Nov 22, 2021

Fixes #5019

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

To resolve #5019 this PR adds a new prop labelHelperText to FormGroup which adds helperText between label and children.

Reviewers should focus on:

We could have ignored the labelHelperText if label is empty, but decided against it as it seemed to add unnecessary complexity. Similarly, there's no restriction on specifying only one type of helperText. It looks slightly odd when both helper texts are used, but we may end up using both with one of our use case where we have a list of fields specified as children.

Screenshot

Screen Shot 2021-11-22 at 10 36 24 AM

@mud mud requested a review from adidahiya November 22, 2021 19:03
@blueprint-bot
Copy link

Remove unused class

Previews: documentation | landing | table | modern colors demo

@adidahiya adidahiya changed the title Add label helper text to FormGroup [core] feat(FormGroup): add support for "sub label" text Dec 1, 2021
@adidahiya adidahiya merged commit 702e17e into develop Dec 1, 2021
@adidahiya adidahiya deleted the to/label-helper-text branch December 1, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helper Text for forms should have 'above input' option
3 participants