Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End date time picker not accessible when selecting between small date ranges #5675

Closed
ggdouglas opened this issue Oct 17, 2022 · 1 comment · Fixed by #6445
Closed

End date time picker not accessible when selecting between small date ranges #5675

ggdouglas opened this issue Oct 17, 2022 · 1 comment · Fixed by #6445

Comments

@ggdouglas
Copy link
Contributor

ggdouglas commented Oct 17, 2022

Environment

  • Package version(s): 4.11.3
  • Operating System: macOS
  • Browser name and version: Chrome 106.0.5249.119

Code Sandbox

Link to a minimal repro: https://codesandbox.io/s/blueprint-datetime-end-range-yinb35

Steps to reproduce

Create a DateRangeInput2 component with a minDate and maxDate that spans less than a month and has the time picker enabled. e.g.

<DateRangeInput2
  // ...
  minDate={new Date("2022-10-10 12:00:00")}
  maxDate={new Date("2022-10-20 12:00:00")}
  timePrecision={TimePrecision.MINUTE}
/>

Actual behavior

The time picker for the start time is visible but the end time picker is not. Only the start time can be modified from the picker in the popover.

Expected behavior

The end time picker (which only shows up in the multi-month selection view) should be visible.

Possible solution

Perhaps the singleMonthOnly type behavior can be overwritten when the timePrecision prop is present. Otherwise, it would be nice to have more direct control over how many month panels are rendered. Alternatively, the timepicker controls could be rendered outside of datepicker-content so that they are no longer dependent on the number of months being displayed in the popover.

@StefanoGagliardi

This comment was marked as outdated.

@adidahiya adidahiya self-assigned this Sep 18, 2023
@adidahiya adidahiya added P1 and removed P2 labels Sep 18, 2023
@adidahiya adidahiya removed their assignment Sep 27, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants