[datetime2] fix(DRP3): show both timepickers for single month #6445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmatan
force-pushed
the
rm/single-month-timepickers
branch
from
6631c5d
to
c872a01
Compare
rmatan
force-pushed
the
rm/single-month-timepickers
branch
from
c872a01
to
7af61d2
Compare
always show both timepickers; add stacked stylingBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
changed the title
adidahiya
changed the title
adidahiya
suggested changes
Oct 12, 2023
adidahiya
reviewed
Oct 12, 2023
packages/datetime/src/components/date-range-picker/_daterangepicker.scss
Outdated
Show resolved
Hide resolved
adidahiya
approved these changes
Oct 12, 2023
fix/improve docs examplesBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5675
Checklist
Changes proposed in this pull request:
When showing timepickers with a DateRangePicker3, show both timepickers even if only a single month is showing, so that the user can edit both the start and end time. Previously, only one TimePicker was shown so only the start time could be edited. If
useAmPmis on, or thetimePrecisionis any longer than minutes, stack the TimePickers on top of each other instead of stretching the width.Reviewers should focus on:
Fairly simple change, reviewers should ensure styling looks good with different length time pickers.
Screenshot