Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog doesn't close on Escape key if user clicks inside the Dialog #5782

Closed
tdehollain opened this issue Dec 1, 2022 · 3 comments
Closed

Comments

@tdehollain
Copy link

Environment:
Package version(s): @blueprintjs/core: 4.12.0
Operating System: macOS Ventura 13.0
Browser name and version: Google Chrome Version 107.0.5304.110 (Official Build) (arm64)

Steps to reproduce:

  1. Go to Dialog documentation
  2. Click one of the Show Dialog buttons (make sure the Prop Escape key to close is checked)
  3. Click somewhere inside the dialog, or select some of the text
  4. Press Esc key

Actual behavior:
The Dialog remains open

Expected behavior:
The Dialog should close

@adidahiya
Copy link
Contributor

Yeah, I can confirm this is a bug. Seems related to #2702. I'm open to PRs if anyone has the time to look into this 🙏🏽

@dylangrandmont
Copy link
Contributor

dylangrandmont commented Oct 19, 2023

Looking at the v5 docs page (same link in the original description above) I think this issue may be resolved.

Edit: however the inverse case still appears to be an issue (#6399)

@adidahiya
Copy link
Contributor

thanks @dylangrandmont, you're right, I can no longer repro this either. a similar issue / duplicate was closed recently too: #5947

yes, #6399 is still an issue at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants