Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlays are not closed on esc key after clicking or focusing inside the overlay component #5947

Closed
sher opened this issue Feb 15, 2023 · 3 comments

Comments

@sher
Copy link

sher commented Feb 15, 2023

I guess that the title does explain the situation.

Even canEscapeKeyClose prop is set to true, after you click on any element on the drawer, making it the event receiver, the drawer doesn't close on esc key press.

@adidahiya
Copy link
Contributor

This applies to all overlay components, including Dialog, Popover2, and Drawer. I'll update the title.

@adidahiya adidahiya changed the title Drawer is not closed on esc key after clicking on the Drawer component itself Overlays are not closed on esc key after clicking or focusing inside the overlay component Feb 15, 2023
@alexbrt
Copy link

alexbrt commented Mar 17, 2023

@adidahiya Not sure if it helps, but setting tabIndex={0} on the child component to allow focusing it might fix it.

@adidahiya
Copy link
Contributor

I can no longer repro this bug, but now we have another related one: #6399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants