Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static imported icons display shifted in 5.0.0-beta #6220

Closed
tonooo71 opened this issue Jun 14, 2023 · 2 comments
Closed

Static imported icons display shifted in 5.0.0-beta #6220

tonooo71 opened this issue Jun 14, 2023 · 2 comments
Assignees
@adidahiya
Labels
P1 Package: core Type: bug
Milestone
5.0.0

Comments

@tonooo71
Copy link
Contributor

Environment

  • Package version(s): 5.0.0-beta.0
  • Operating System: Windows 10
  • Browser name and version: Microsoft Edge 113.0.1774.42

Code Sandbox

Link to a minimal repro (fork this code sandbox):

Steps to reproduce

  • add an icon using static imports
  • specify size (e.g. 32)
import { Bug } from "@blueprintjs/icons";

render(<Bug size={32} />)

Actual behavior

bp5-alpha4

(This is in 5.0.0-alpha.4)
(I added borders for clarity.)

Expected behavior

bp5-beta0

(This is in 5.0.0-beta.0)
(I added borders for clarity.)

Possible solution
@adidahiya adidahiya self-assigned this Jun 14, 2023
@adidahiya adidahiya added this to the 5.0.0 milestone Jun 14, 2023
@adidahiya
Copy link
Contributor

Thanks for the bug report, I'll look into it.

adidahiya added a commit that referenced this issue Jun 14, 2023
@adidahiya
fix #6220, add example to verify fix
39a71df
@adidahiya adidahiya mentioned this issue Jun 14, 2023
Merged
@tonooo71
Copy link
Contributor Author

Thank you for the fix!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adidahiya adidahiya

Labels
P1 Package: core Type: bug
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@adidahiya @tonooo71