Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor simple class components into functions #6289

Closed
5 of 22 tasks
adidahiya opened this issue Jul 19, 2023 · 0 comments · Fixed by #6800 or #6830 · May be fixed by #6806, #6815 or #6817
Closed
5 of 22 tasks

Refactor simple class components into functions #6289

adidahiya opened this issue Jul 19, 2023 · 0 comments · Fixed by #6800 or #6830 · May be fixed by #6806, #6815 or #6817
Labels
P2 Package: core Type: breaking change Type: feature request
Milestone
6.0.0

Comments

@adidahiya
Copy link
Contributor

adidahiya commented Jul 19, 2023 •
edited by ggdouglas
Loading

Environment

  • Package version(s): @blueprintjs/core v5.x

Feature request

Request to refactor simple class components into functions, which would allow:

As of @blueprintjs/core v5.1.x, these include:

  • Breadcrumbs
  • Callout
  • Collapse
  • Dialog
  • DialogBody
  • DialogFooter
  • Divider
  • Drawer
  • FileInput
  • FormGroup
  • InputGroup
  • KeyComboTag
  • Menu
  • MenuDivider
  • Navbar
  • NavbarDivider
  • NavbarGroup
  • NonIdealState
  • ProgressBar
  • RadioGroup
  • Spinner
  • TextArea

This would be a ⚠️ breaking change ⚠️
@adidahiya adidahiya added this to the 6.0.0 milestone Jul 19, 2023
@adidahiya adidahiya mentioned this issue Aug 25, 2023
Open
@adidahiya adidahiya mentioned this issue Jan 16, 2024
Merged
5 tasks
This was referenced May 15, 2024
Merged
Open
Merged
Open
This was referenced May 22, 2024
Open
Merged
Open
Open
Open
Merged
Merged
Open
Open
Merged
Open
Open
Open
@ggdouglas ggdouglas reopened this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Package: core Type: breaking change Type: feature request
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

feat(Callout): refactor callout to functional component ahmadJT/blueprint
chore(NavbarGroup): refactor nav bar group to functional component ahmadJT/blueprint
feat(Dialog): refactor dialog to functional component ahmadJT/blueprint
feat(Drawer): refactored drawer to functional component ahmadJT/blueprint
feat(DialogFooter): refactored dialog footer to functional component ahmadJT/blueprint
chore(InputGroup): refactored input group component to a functional component ahmadJT/blueprint
chore(NonIdealState): refactored non ideal state component to a functional component ahmadJT/blueprint
chore(KeyComboTag): refactor key combo tag component to a functional component ahmadJT/blueprint
chore(NavBar): refactor nav bar to functional component ahmadJT/blueprint
chore(NavbarDivider): refactor nav bar divider to functional component ahmadJT/blueprint
2 participants
@adidahiya @ggdouglas