-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DialogFooter): refactored dialog footer to functional component #6817
base: develop
Are you sure you want to change the base?
feat(DialogFooter): refactored dialog footer to functional component #6817
Conversation
Generate changelog in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting some minor changes, but otherwise looking good
{actions && <div className={Classes.DIALOG_FOOTER_ACTIONS}>{actions}</div>} | ||
</div> | ||
); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add displayName
here?
}; | |
}; | |
DialogFooter.displayName = `${DISPLAYNAME_PREFIX}.DialogFooter`; |
return <div className={Classes.DIALOG_FOOTER_MAIN_SECTION}>{this.props.children}</div>; | ||
} | ||
|
||
/** Optionally render the footer actions (right aligned). */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we preserve these comments in the refactored structure of the component?
{/* Render the main footer section (left aligned). */}
<div className={Classes.DIALOG_FOOTER_MAIN_SECTION}>{children}</div>
{/* Optionally render the footer actions (right aligned). */}
{actions && <div className={Classes.DIALOG_FOOTER_ACTIONS}>{actions}</div>}
Fixes #6289
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot