[Table] Add docs about reorderable content #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llorca
approved these changes
Jun 22, 2017
Merge branch 'master' into cl/table-reorder-handlePreview: documentation | table |
cmslewis
added a commit
that referenced
this pull request
Jun 22, 2017
* Add Utils.some
* [Temporary] Change feature flags in Table example
* Add new classes for reorder handle
* Add ignoredSelector prop to DragSelectable
* Add preliminary styles for reorder handle
* Add reorder handle to column interaction bar
* Ignore reorder handle selector
* Reorder handle works
* Renable drag-reordering on rows
* Delete commented code
* Show column grab cursor only over reorder handle
* Move selection only if it existed before reorder
* Don't disable drage selection for column headers
* Different handle colors on :hover and :active
* Delete console.logs
* Select clicked handle's column if not selected
* Reenable old reordering interaction if useInteractionBar={false}
* Delete reorderHandle.tsx, put Orientation back in resizeHandle.tsx
* Code cleanups
* Rename to isEntireCellTargetReorderable
* Delete orientation.ts
* Have Header apply the TABLE_HEADER_REORDERABLE class
* Reply to CR feedback
* Fix tests
* Write new tests, fix bug
* Add deprecation warning to HeaderCell#isReorderable
* Fix lint
* Fix deprecation version
* Fix deprecation message
* Add reorderable example to site-docs
Merged
cmslewis
added a commit
that referenced
this pull request
Jun 22, 2017
* Prepare Release 1.21.0 * [Table] Add docs about reorderable content (#1271) * Add Utils.some * [Temporary] Change feature flags in Table example * Add new classes for reorder handle * Add ignoredSelector prop to DragSelectable * Add preliminary styles for reorder handle * Add reorder handle to column interaction bar * Ignore reorder handle selector * Reorder handle works * Renable drag-reordering on rows * Delete commented code * Show column grab cursor only over reorder handle * Move selection only if it existed before reorder * Don't disable drage selection for column headers * Different handle colors on :hover and :active * Delete console.logs * Select clicked handle's column if not selected * Reenable old reordering interaction if useInteractionBar={false} * Delete reorderHandle.tsx, put Orientation back in resizeHandle.tsx * Code cleanups * Rename to isEntireCellTargetReorderable * Delete orientation.ts * Have Header apply the TABLE_HEADER_REORDERABLE class * Reply to CR feedback * Fix tests * Write new tests, fix bug * Add deprecation warning to HeaderCell#isReorderable * Fix lint * Fix deprecation version * Fix deprecation message * Add reorderable example to site-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to push these final commits before I merged #1242. :(