Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More accurate icons for selects #1366

Merged
merged 1 commit into from
Jul 25, 2017
Merged

More accurate icons for selects #1366

merged 1 commit into from
Jul 25, 2017

Conversation

llorca
Copy link
Contributor

@llorca llorca commented Jul 20, 2017

Native <select> should be the double caret similarly to the native one:
screen shot 2017-07-19 at 5 00 31 pm

Our custom <Select> is more like a dropdown, can get caret down as used elsewhere:
screen shot 2017-07-19 at 5 00 51 pm

@llorca llorca requested review from cmslewis and giladgray July 20, 2017 00:03
cmslewis
cmslewis approved these changes Jul 20, 2017
View reviewed changes
Copy link
Contributor

@cmslewis cmslewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@blueprint-bot
Copy link

More accurate icons for selects

Preview: documentation
Coverage: core | datetime

@giladgray giladgray merged commit 85a42b2 into master Jul 25, 2017
@giladgray giladgray deleted the al/select-icons branch July 25, 2017 19:12
@giladgray giladgray mentioned this pull request Jul 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmslewis cmslewis cmslewis approved these changes

@giladgray giladgray giladgray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llorca @blueprint-bot @cmslewis @giladgray