Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update development dependencies throughout #1376

Merged
merged 6 commits into from
Jul 24, 2017
Merged

update development dependencies throughout #1376

merged 6 commits into from
Jul 24, 2017

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Jul 24, 2017

Changes proposed in this pull request:

updated to latest versions
  • stylelint @ 8 (necessary for editor integration with new rules)
  • karma @ 1.7.0
  • node-sass @ 4.5.3 (necessary for latest Node compat)
  • all gulp plugins
  • webpack loaders (to latest 1.x-compat version)
not updated
  • webpack still @ 1

Reviewers should focus on:

  • no weird errors in build output

Gilad Gray added 6 commits July 21, 2017 16:07
stylelint@8! postcss-url@7 supports copying assets so we can remove
postcss-copy-assets entirely. (Note: resource paths are now
dist/resources, not dist/assets)
@@ -4,13 +4,14 @@
"stylelint-config-palantir/sass.js"
],
"rules": {
"declaration-empty-line-before": null,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this new rule is nice but would require sweeping changes to support:
either adding empty lines before decls, or removing the handful that are there. also removing empty lines between property groups, which are helpful when we use them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I'm not a fan of with the current behavior is how it disallows empty lines after @include declarations (i.e. react-transition). Does this rule address that?

@@ -113,7 +113,7 @@ const projects = [
],
},
copy: {
"resources/favicon.png": { to: ["assets/"], base: "resources/" },
"resources/favicon.png": { to: ["resources/"], base: "resources/" },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postcss-url preserves the resources/ directory name.
site-landing webpack build moves them all into assets/, so those don't change.
site-docs gets copied over directly into docs/docs/, so its paths will change with next release.

@blueprint-bot
Copy link

upgrade site-landing dev deps

Preview: documentation | landing | table
Coverage: core | datetime

@giladgray giladgray merged commit aac0f58 into master Jul 24, 2017
@giladgray giladgray deleted the gg/dev-deps branch July 24, 2017 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants