-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update development dependencies throughout #1376
Conversation
stylelint@8! postcss-url@7 supports copying assets so we can remove postcss-copy-assets entirely. (Note: resource paths are now dist/resources, not dist/assets)
@@ -4,13 +4,14 @@ | |||
"stylelint-config-palantir/sass.js" | |||
], | |||
"rules": { | |||
"declaration-empty-line-before": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this new rule is nice but would require sweeping changes to support:
either adding empty lines before decls, or removing the handful that are there. also removing empty lines between property groups, which are helpful when we use them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I'm not a fan of with the current behavior is how it disallows empty lines after @include
declarations (i.e. react-transition
). Does this rule address that?
@@ -113,7 +113,7 @@ const projects = [ | |||
], | |||
}, | |||
copy: { | |||
"resources/favicon.png": { to: ["assets/"], base: "resources/" }, | |||
"resources/favicon.png": { to: ["resources/"], base: "resources/" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postcss-url preserves the resources/
directory name.
site-landing
webpack build moves them all into assets/
, so those don't change.
site-docs
gets copied over directly into docs/docs/
, so its paths will change with next release.
upgrade site-landing dev depsPreview: documentation | landing | table |
Changes proposed in this pull request:
updated to latest versions
not updated
Reviewers should focus on: