[Icon] Fix pt-icon-bank-account className #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmslewis
approved these changes
Aug 16, 2017
Fix pt-icon-bank-account classNamePreview: documentation |
|
@llorca wait, does this mean people had to write stuff like |
|
Yeah that's probably true, but I doubt anybody would've used it without calling out the error. In any case, that fix seems fine to me -- don't think it'd be appropriate to wait for 2.0 for such a thing? |
|
Yeah waiting to 2.0 seems like overkill. Just wanted to call it out. EDIT: Updated the PR description. |
|
Let's get one more opinion from @adidahiya or @giladgray before we merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1455
(Technically a breaking change, but we think it'd be silly to wait for 2.0 for such a small correction)