Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Fix Table sizing when shown in flex parent #1479

Merged
merged 6 commits into from
Aug 22, 2017
Merged

[Table] Fix Table sizing when shown in flex parent #1479

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f260119
Style fixes when table is within a display: flex container
cmslewis Aug 21, 2017
ef46d67
Remove unnecessary rules
cmslewis Aug 21, 2017
c1cef0e
Clearer comment
cmslewis Aug 21, 2017
b2be1fe
Try to fix lint
cmslewis Aug 22, 2017
f1d50c7
Fix tests
cmslewis Aug 22, 2017
77c3408
Little CSS polishes
cmslewis Aug 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/table/src/quadrants/_quadrants.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@ $table-quadrant-scroll-container-overflow: 20px;

.bp-table-quadrant-scroll-container {
position: absolute;
top: 0;
right: -$table-quadrant-scroll-container-overflow;
height: 100%;
bottom: 0;
height: auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is entirely necessary, but won't hurt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever I specify both top and bottom, I like to take height out of the picture so the two schemes don't compete unpredictably.

overflow-x: hidden;
}
}
Expand Down