Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Fix for user-land sass compilation #1483

Merged
merged 1 commit into from
Aug 22, 2017
Merged

[Table] Fix for user-land sass compilation #1483

merged 1 commit into from
Aug 22, 2017

Conversation

tyscorp
Copy link
Contributor

@tyscorp tyscorp commented Aug 22, 2017

Similar issue to #1456, but when importing the table's scss.

Without this I get File to import not found or unreadable: ../../core/src/common/mixins. and File to import not found or unreadable: ./common/variables.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @tyscorp! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@llorca llorca requested a review from cmslewis August 22, 2017 17:58
Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

@cmslewis cmslewis merged commit 22c69ce into palantir:master Aug 22, 2017
cmslewis added a commit that referenced this pull request Aug 23, 2017
* [Table] Fix Table sizing when shown in flex parent (#1479)

* Style fixes when table is within a display: flex container

* Remove unnecessary rules

* Clearer comment

* Try to fix lint

* Fix tests

* Little CSS polishes

* Prepare Release 1.25.2

* fix normalize.css version on docs site (#1478)

* fix normalize.css version in site-docs
* rebuild site-docs.css

* Rebuild

* [Table] Fix for user-land sass compilation (#1483)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants