[Table/EditableCell] Only update saved and dirty values if value changed #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only update saved and dirty values if value changedPreview: documentation | table |
cmslewis
reviewed
Oct 3, 2017
| this.setState({ savedValue: value, dirtyValue: value }); | ||
| if (value !== this.props.value) { | ||
| this.setState({ savedValue: value, dirtyValue: value }); | ||
| } |
There was a problem hiding this comment.
Cool! Now, how do we unit-test this?
(Or more explicitly: can you add one?)
There was a problem hiding this comment.
Heh. It should be doable, I guess.
cmslewis
changed the title
gscshoyru
force-pushed
the
gsc/fix-editable-value-update
branch
from
79f9d62
to
44b009c
Compare
Add testPreview: documentation | table |
cmslewis
approved these changes
Oct 5, 2017
| expect(input.element).to.equal(document.activeElement); | ||
|
|
||
| // edit | ||
| input.change("my-changed-value"); |
There was a problem hiding this comment.
Whaaat is this glorious .change(...) magic.
| expect(onConfirm.called).to.be.false; | ||
| expect(elem.find(".pt-editable-content").text()).to.equal("my-changed-value"); | ||
|
|
||
| harness.mount( |
There was a problem hiding this comment.
So this is functionally equivalent to setProps?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1261
Changes proposed in this pull request:
We were updating saved and dirty value to match the value whenever any prop changed, no matter what. Even if
shouldComponentUpdatewould have returned false, becausecomponentWillReceivePropsis always true. So if there were any changes made before rendering got there (because batched rendering), it'd reset those changes. Now this no longer happens.Reviewers should focus on:
Is
componentWillReceivePropseven the right place for this? It apparently can't live incomponentWillUpdatebecause that won't take asetState, but... is there a better lifecycle spot for this?Or more generally: is there a better way to do what I'm doing?