Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Submenus] Switch popover from relative to absolute positioning #1672

Merged
merged 1 commit into from
Oct 5, 2017
Merged

[Submenus] Switch popover from relative to absolute positioning #1672

merged 1 commit into from
Oct 5, 2017

Conversation

llorca
Copy link
Contributor

@llorca llorca commented Oct 5, 2017 •
edited
Loading

Fixes #1668

Checklist

  • Include tests

Changes proposed in this pull request:

Change the position of submenu popovers to be absolute instead of relative

Reviewers should focus on:

Any particular reason why it was relative in the first place?

@tgreenwatts
Copy link
Contributor

I'll check it out when the preview comes up on IE!

@blueprint-bot
Copy link

Switch submenu popover from relative to absolute positioning

Preview: documentation
Coverage: core | datetime

@tgreenwatts
Copy link
Contributor

Looks great
image

@cmslewis
Copy link
Contributor

cmslewis commented Oct 5, 2017

The line git blames to @giladgray. Gilad, remember why we used position: relative?

cmslewis
cmslewis approved these changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@cmslewis cmslewis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works. :)

@cmslewis cmslewis merged commit 87939cb into master Oct 5, 2017
@cmslewis cmslewis deleted the al/ie-submenus branch October 5, 2017 23:02
@cmslewis cmslewis mentioned this pull request Oct 6, 2017
Merged
@mfedderly mfedderly mentioned this pull request Nov 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgreenwatts tgreenwatts tgreenwatts approved these changes

@cmslewis cmslewis cmslewis approved these changes

@giladgray giladgray Awaiting requested review from giladgray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llorca @tgreenwatts @blueprint-bot @cmslewis