[DateInput] Selected value stays selected when canClearSelection=false with timePrecision enabled #1792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1737
Checklist
Changes proposed in this pull request:
BEFORE:
DateInput
withcanClearSelection=false
andtimePrecision
enabled.onChange
is erroneously emitted withnull
, suggesting that the date has just been deselected, which shouldn't be possible.AFTER:
DateInput
no longer emitsonChange
withnull
when clicking selected date withcanClearSelection=false
withtimePrecision
enabled.Reviewers should focus on:
Nothing in particular. Easy fix.
Screenshot
Here's a working example with the following props: