Graduate Labs Components - Part 1: Move TagInput, Popover2, Tooltip2 into core/ #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build is broken b/c Popover2 depends on Tooltip2
cmslewis
force-pushed
the
cl/graduate-labs-to-core
branch
from
923f2d7
to
e7032c8
Compare
Ignore test coverage for these files for nowPreview: documentation |
cmslewis
requested review from
giladgray,
themadcreator,
adidahiya,
hellochar and
jkillian
Merge branch 'master' into cl/graduate-labs-to-corePreview: documentation |
cmslewis
changed the title
3 tasks
adidahiya
requested review from
gscshoyru
and removed request for
adidahiya and
jkillian
giladgray
approved these changes
Dec 12, 2017
| @@ -11,6 +11,10 @@ module.exports = function (config) { | |||
| dirname: __dirname, | |||
| coverageExcludes: [ | |||
| "src/accessibility/*", | |||
| // TODO (clewis): write tests for these component as part of the 2.0 effort: | |||
There was a problem hiding this comment.
what about Popover2Tests?
| "pure-render-decorator": "^1.1", | ||
| "react-popper": "~0.7.4", | ||
| "tether": "^1.4", |
|
|
||
| `TagInput` renders [`Tag`](#core/components/tag)s inside an input, followed by an actual text input. The container is merely styled to look like a Blueprint input; the actual editable element appears after the last tag. Clicking anywhere on the container will focus the text input for seamless interaction. | ||
| Tag inputs render [`Tag`](#core/components/tag)s inside an input, followed by an actual text input. The container is merely styled to look like a Blueprint input; the actual editable element appears after the last tag. Clicking anywhere on the container will focus the text input for seamless interaction. |
There was a problem hiding this comment.
hmm I preferred the TagInput usage to clarify that it's one thing (not two words) and that there's only a React API for it.
| import * as Classes from "../../common/classes"; | ||
| import * as Keys from "../../common/keys"; | ||
| import { HTMLInputProps, IProps } from "../../common/props"; | ||
| import * as Utils from "../../common/utils"; |
There was a problem hiding this comment.
could import just the used utils?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
TagInput,Popover2, andTooltip2fromlabs/intocore/.Next steps (each in a separate PR, probably):
TooltipandPopoverfromcore/; renamePopover2andTooltip2toPopoverandTooltip, respectively; deletetetherdependency; fix build failures.Popover2.isDisabled).Tooltip2,Popover, andTagInput;and remove them from karmacoverageExcludes.