Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use normalize v7 #1886

Merged
merged 3 commits into from
Dec 12, 2017
Merged

use normalize v7 #1886

merged 3 commits into from
Dec 12, 2017

Conversation

giladgray
Copy link
Contributor

Fixes #1477

Changes proposed in this pull request:

Normalize v4.1.1 ⇒ v7.0.0 changelog

manually diffed code; changes seem safe and actually includes some good fixes!

manually diffed code; changes seem safe and actually includes some good fixes!
@blueprint-bot
Copy link

use normalize v7

Preview: documentation

@adidahiya
Copy link
Contributor

needs careful design review but generally 👍

Copy link
Contributor

@cmslewis cmslewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at typography, examples, etc. in the documentation. Didn't find anything amiss, so LGTM. Let's wait for @llorca's approval before merging.

@llorca
Copy link
Contributor

llorca commented Dec 12, 2017

Going through every component now!

@llorca
Copy link
Contributor

llorca commented Dec 12, 2017

  • button.pt-button has a font family problem: sans-serif instead of our custom system one. a.pt-button is fine

@llorca
Copy link
Contributor

llorca commented Dec 12, 2017

Everything else looks good 👍

@blueprint-bot
Copy link

inherit font-family on .pt-button and .pt-key

Preview: documentation | landing | table

@blueprint-bot
Copy link

Merge branch 'master' into gg/normalize

Preview: documentation

@adidahiya adidahiya merged commit 19ce170 into master Dec 12, 2017
@adidahiya adidahiya deleted the gg/normalize branch December 12, 2017 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants