Table Renames. render* -> *Renderer. Focus -> FocusedCell. *Header -> *HeaderCell. #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes - allowMultipleSelection enableMultipleSelection - fillBodyWithGhostCells enableGhostCells - isColumnReorderable enableColumnReordering - isColumnResizable enableColumnResizing - isRowHeaderShown enableRowHeader - isRowReorderable enableRowReordering - isRowResizable enableRowResizing - enableFocus enableFocusedCell - onFocus onFocusedCell - renderBody bodyRenderer - renderBodyContextMenu bodyContextMenuRenderer - renderColumnHeader columnHeaderCellRenderer - renderRowHeader rowHeaderCellRenderer - useInteractionBar enableColumnInteractionBar
themadcreator
changed the title
lintPreview: documentation | table |
gscshoyru
approved these changes
Dec 12, 2017
adidahiya
reviewed
Dec 12, 2017
| allowMultipleSelection={this.state.enableMultiSelection} | ||
| enableFocus={this.state.showFocusCell} | ||
| fillBodyWithGhostCells={this.state.showGhostCells} | ||
| enableMultipleSelection={this.state.enableMultiSelection} |
There was a problem hiding this comment.
nit: alphabetize all these
| @@ -44,7 +44,7 @@ export interface IColumnProps extends IColumnNameProps, IProps { | |||
| * An instance of `IColumnHeaderRenderer`, a function that takes a column | |||
There was a problem hiding this comment.
I think renderCell (above) should be renamed to cellRenderer as well..?
packages/table/src/table.tsx
Outdated
| @@ -248,7 +248,7 @@ export interface ITableProps extends IProps, IRowHeights, IColumnWidths { | |||
| * contain all selected regions. Otherwise it will have one `IRegion` that | |||
| * represents the clicked cell. | |||
| */ | |||
| renderBodyContextMenu?: IContextMenuRenderer; | |||
| bodyContextMenuRenderer?: IContextMenuRenderer; | |||
There was a problem hiding this comment.
alphabetize props in interfaces
packages/table/src/tableBody.tsx
Outdated
| @@ -40,7 +40,7 @@ export interface ITableBodyProps extends ISelectableProps, ITableBodyCellsProps | |||
| * on the table body. The callback is supplied with an `IMenuContext` | |||
| * containing the `IRegion`s of interest. | |||
| */ | |||
| renderBodyContextMenu?: IContextMenuRenderer; | |||
| bodyContextMenuRenderer?: IContextMenuRenderer; | |||
lintPreview: documentation | table |
adidahiya
approved these changes
Dec 12, 2017
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames: