Tabs2 ➡️ Tabs #1900
Tabs2 ➡️ Tabs #1900
Conversation
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2015 Palantir Technologies, Inc. All rights reserved. | |||
| * Copyright 2017 Palantir Technologies, Inc. All rights reserved. | |||
There was a problem hiding this comment.
I'm down to leave the original date.
There was a problem hiding this comment.
I like to use 2015-present since it's never out of date
| export const Home = () => <Tabs selectedTabIndex={0}>{contents}</Tabs>; | ||
| export const Projects = () => <Tabs selectedTabIndex={1}>{contents}</Tabs>; | ||
| export const Home = () => <Tabs selectedTabId="home">{contents}</Tabs>; | ||
| export const Projects = () => <Tabs selectedTabId="projects">{contents}</Tabs>; |
There was a problem hiding this comment.
@adidahiya are these updates correct? is this section still useful?
There was a problem hiding this comment.
hmm, we should probably remove this react router section because it probably doesn't work with react-router v4. we can add it back if requested by users.
and fix all the *other* usagesPreview: documentation |
|
@adidahiya - waited, resolved merged conflicts. |
copyright yearPreview: documentation |
| export const Home = () => <Tabs selectedTabIndex={0}>{contents}</Tabs>; | ||
| export const Projects = () => <Tabs selectedTabIndex={1}>{contents}</Tabs>; | ||
| export const Home = () => <Tabs selectedTabId="home">{contents}</Tabs>; | ||
| export const Projects = () => <Tabs selectedTabId="projects">{contents}</Tabs>; |
There was a problem hiding this comment.
hmm, we should probably remove this react router section because it probably doesn't work with react-router v4. we can add it back if requested by users.
|
you probably need to merge master to fix the overlay test flake. |
Merge branch 'master' of github.com:palantir/blueprint into gg/tabsPreview: documentation | table |
Tabs2replaces originalTabsAPI.