-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename bp-table -> pt-table. Upgrade script updates #1906
Conversation
Run script over packagesPreview: documentation | table |
@@ -35,7 +35,7 @@ | |||
|
|||
// CSS examples | |||
|
|||
#{reference("pt-file-upload")}, | |||
#{reference("pt-file-input")}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this one missed from #1880 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it. Good thing we have a script!
Add features page back to dev preview distPreview: documentation | table |
Merge remote-tracking branch 'origin/master' into bd/rename-bp-classesPreview: documentation | table |
Fix features previewPreview: documentation | landing | table |
@themadcreator @adidahiya @giladgray @llorca I really don't like that Ideas:
|
Just kidding -- include CSSPreview: documentation | table |
Rename pt-table -> pt-html-tablePreview: documentation | table |
@@ -7,7 +7,7 @@ Color aliases | |||
These variables are semantic aliases of our [colors](#colors). They are used throughout Blueprint | |||
itself to ensure consistent color usage across components. | |||
|
|||
<table class=pt-table> | |||
<table class=pt-html-table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing quotes. though it seems to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def works. let's add them for good measure
packages/core/src/common/classes.ts
Outdated
@@ -156,7 +156,7 @@ export const TAB_LIST = "pt-tab-list"; | |||
export const TAB_PANEL = "pt-tab-panel"; | |||
export const TABS = "pt-tabs"; | |||
|
|||
export const TABLE = "pt-table"; | |||
export const TABLE = "pt-html-table"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we rename constant too, to match?
} | ||
|
||
function renameString() { | ||
# Don't add word boundary so that partial css classnames rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah this is invalid
} | ||
|
||
function renamePartialClass() { | ||
# Don't add word boundary so that partial css classnames rename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, this is still relevant, notice how we don't add the the \\b
to this one.
renderName -> nameRenderer. Review docs, fix old referencesPreview: documentation | table |
…dered. script comment
pt-striped -> pt-html-table-striped. pt-borderer -> pt-html-table-bordered. script commentPreview: documentation | table |
Add other prefixes to rename script for protected abstract membersPreview: documentation | table |
packages/table/src/table.tsx
Outdated
rowHeaderCellRenderer={this.renderRowHeader} | ||
rowHeaderRef={this.refHandlers.rowHeader} | ||
scrollContainerRef={this.refHandlers.scrollContainer} | ||
/> | ||
<div className={classNames(Classes.TABLE_OVERLAY_LAYER, "bp-table-reordering-cursor-overlay")} /> | ||
<div className={classNames(Classes.TABLE_OVERLAY_LAYER, "pt-table-reordering-cursor-overlay")} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we should make this a constant in Classes
Extract constPreview: documentation | table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge when CI passes
Merge remote-tracking branch 'refs/remotes/origin/master' into bd/rename-bp-classesPreview: documentation | table |
Add rename for all classname strings
bp-table
->pt-table
Change
onFocus
from rename to warning since it's likely to clobber common usesAdd other core renames to script